hdmf-dev / hdmf-zarr

Zarr I/O backend for HDMF
https://hdmf-zarr.readthedocs.io/
Other
7 stars 7 forks source link

numpy degrade for python 3.7 #115

Closed mavaylon1 closed 1 year ago

mavaylon1 commented 1 year ago

Motivation

What was the reasoning behind this change? Please explain the changes briefly. Update python that supports 3.7. This is meant to address the fact that the Read the Docs for HDMF-Zarr does not build.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Run the tests and check read the docs build

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (086c9bc) 81.92% compared to head (90e8537) 81.92%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #115 +/- ## ======================================= Coverage 81.92% 81.92% ======================================= Files 11 11 Lines 2667 2667 ======================================= Hits 2185 2185 Misses 482 482 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rly commented 1 year ago

As a quick fix, this is fine but we also do not need to support Python 3.7 anymore unless there is a good reason to. We have migrated HDMF to Python 3.8 minimum.

mavaylon1 commented 1 year ago

As a quick fix, this is fine but we also do not need to support Python 3.7 anymore unless there is a good reason to. We have migrated HDMF to Python 3.8 minimum.

Correct and there is a PR to make that upgrade (#105). What made us stop was the fact the export/cache bug preventing us from using a more recent version of HDMF to then drop 3.7. @rly

mavaylon1 commented 1 year ago

@oruebel @rly This does fix this build issue. I will clean it up tomorrow. I am aware of 3.7 being dropped and the export/cache issue is the main bump we will get through to bring hdmf-zarr up to speed with hdmf.