Closed mavaylon1 closed 11 months ago
Fix #121 Fix #113 Fix #106 Fix #79
Attention: 34 lines
in your changes are missing coverage. Please review.
Comparison is base (
6c13e14
) 81.73% compared to head (f3d1abe
) 84.73%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rly I did the updates for using export_source for a flag; however, we would need to flush it out more with the export updates in the future. (specifically in links). The scope of these this PR is getting to large.
We should also update the note here https://github.com/hdmf-dev/hdmf-zarr/blob/dev/docs/source/storage.rst#region-references to mention that the new resolver classes will also need to be updated to implement region references
We should also update the note here https://github.com/hdmf-dev/hdmf-zarr/blob/dev/docs/source/storage.rst#region-references to mention that the new resolver classes will also need to be updated to implement region references
Done.
This looks good to me. I'll let @oruebel do the final approval.
Thanks for your hard work on this!
Motivation
What was the reasoning behind this change? Please explain the changes briefly. This branch holds the re-work of the ZarrIO backend on how it handles object references. The changes are to follow the same workflow HDMF has when handling object references.
With the changes to the backend, we have a temporary ignore on dtype conversion. It is has been raised in this ticket: https://github.com/hdmf-dev/hdmf-zarr/pull/120
This PR removes python 3.7, brings hdmf and pynwb to the most up to date, as well updates to the workflows.
How to test the behavior?
Run unit tests and gallery examples, specifically test_io_convert.py and plot_convert_nwb_hdf5.py
Checklist
ruff
from the source directory.