hdmf-dev / hdmf-zarr

Zarr I/O backend for HDMF
https://hdmf-zarr.readthedocs.io/
Other
7 stars 7 forks source link

Fix #127 update paralle write test to set table ids #128

Closed oruebel closed 11 months ago

oruebel commented 11 months ago

Motivation

Fix #127 update parallel write test to set table ids when all columns are iterators

How to test the behavior?

Run pytest on the dev branch using HDMF on dev

Checklist

codecov-commenter commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (7e1a82e) 85.66% compared to head (2ab6711) 85.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #128 +/- ## ======================================= Coverage 85.66% 85.66% ======================================= Files 13 13 Lines 3139 3139 ======================================= Hits 2689 2689 Misses 450 450 ``` | [Files](https://app.codecov.io/gh/hdmf-dev/hdmf-zarr/pull/128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hdmf-dev) | Coverage Δ | | |---|---|---| | [tests/unit/test\_parallel\_write.py](https://app.codecov.io/gh/hdmf-dev/hdmf-zarr/pull/128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hdmf-dev#diff-dGVzdHMvdW5pdC90ZXN0X3BhcmFsbGVsX3dyaXRlLnB5) | `98.57% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mavaylon1 commented 11 months ago

@oruebel I'll approve this since the changes are minimal, but lets set up a time to talk about the parallel write after I take a look at what you and Cody have been doing.

mavaylon1 commented 11 months ago

@oruebel Do you need to update the changelog?

oruebel commented 11 months ago

@oruebel Do you need to update the changelog?

Thanks @mavaylon1 . I updated the changlog. Since this PR only fixes an issue of a PR that is part of the same release, I only added an additional link to this PR for the corresponding item that was already in the CHANGLOG.