hdmf-dev / hdmf-zarr

Zarr I/O backend for HDMF
https://hdmf-zarr.readthedocs.io/
Other
7 stars 7 forks source link

Workflows #129

Closed mavaylon1 closed 9 months ago

mavaylon1 commented 11 months ago

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Add workflows that exist in HDMF: ruff (to replace flake8) and codespell.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Run the workflows

Checklist

codecov-commenter commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (9f6c386) 85.66% compared to head (f68d999) 85.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #129 +/- ## ======================================= Coverage 85.66% 85.66% ======================================= Files 13 13 Lines 3139 3139 ======================================= Hits 2689 2689 Misses 450 450 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mavaylon1 commented 11 months ago

@rly @oruebel I'm adding these workflows and I suppose a larger question is coming up: "Should this PR also include the shift from setup.py to pyproject.toml/remove versioneer to how hdmf handles versions with hatch". I ask this because flake8 is setup through the .cfg and HDMF replaced flake8 with ruff (which is handled in the pyproject.toml). I'm thinking that this PR can be:

  1. Bring the workflows up to HDMF
  2. switch to pyproject.toml
  3. Switch version control to hatch The only thing that this would wait for is the fix to the release bug I showed @rly on Friday that creates a wheel with the wrong version. Once that fix is in HDMF, that can also be included here. I think this can be done this week depending on the release bug. I also created a ticket for the bug: https://github.com/hdmf-dev/hdmf/issues/956
mavaylon1 commented 11 months ago

This PR is not ready for review, nor have I finished supporting these new workflows.

rly commented 11 months ago

Yes, let's do a full update so that the testing and maintenance infrastructure is the same as in hdmf.