Closed mavaylon1 closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
70bf35b
) 85.92% compared to head (5185146
) 85.92%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fix #126
@oruebel As I was making this, I started to think about how much did we want to test. Within tox.ini, it installs the latest release of HDMF. It will run pytest according to different environment versions.
Now ideally, this workflow could do something like that, but we can't use tox.ini because we would have to edit the install requirements to use the dev branch. What I have now is a proof of concept that it works for only python 3.11. Do we want this workflow to only do that or should we get creative and test for all python versions?
@mavaylon1 I think testing on python 3.11 (or whatever is the latest version supported by both packages) is sufficient. We could test this workflow on all python versions, on all OSs, with minimum, pinned, upgraded, and pre-release requirements, but I think that is overkill and unlikely to catch issues.
Unlikely to catch any issues that testing on each package independently would not catch.
Unlikely to catch any issues that testing on each package independently would not catch.
Agreed.
Since this is a workflow change, I am not updating the Changelog
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
This introduces a new workflow to run the tests on HDMF-Zarr using the dev branch of HDMF.
How to test the behavior?
Checklist
ruff
from the source directory.