search

hdmf-dev / hdmf-zarr

Zarr I/O backend for HDMF
https://hdmf-zarr.readthedocs.io/
Other
7 stars 6 forks source link

Update pyproject.toml and remove setup.py #143

Closed mavaylon1 closed 10 months ago

mavaylon1 commented 10 months ago

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

codecov-commenter commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9c3b4be) 86.45% compared to head (246f105) 84.51%.

Files Patch % Lines
src/hdmf_zarr/backend.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #143 +/- ## ========================================== - Coverage 86.45% 84.51% -1.95% ========================================== Files 14 5 -9 Lines 3279 1104 -2175 Branches 0 296 +296 ========================================== - Hits 2835 933 -1902 + Misses 444 115 -329 - Partials 0 56 +56 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mavaylon1 commented 10 months ago

Fix #110, #91

mavaylon1 commented 10 months ago

Note: I built locally and the version is correct. Let's aim for a release to test the real thing. (After other PRs are also merged)

oruebel commented 10 months ago

Thanks @mavaylon1. @rly could you please review this one. I think it looks good but you are more familiar with the versioning and deployment workflows.

rly commented 10 months ago

Please delete setup.py

rly commented 10 months ago

Please also delete setup.cfg

rly commented 10 months ago

Please update the required checks so that flake8 is not required but ruff is.

mavaylon1 commented 10 months ago

@rly I deleted flake8 can you approve again.