search

hdmf-dev / hdmf-zarr

Zarr I/O backend for HDMF
https://hdmf-zarr.readthedocs.io/
Other
7 stars 7 forks source link

[CI]: Compare vs. last commit in black CI action #151

Open sneakers-the-rat opened 8 months ago

sneakers-the-rat commented 8 months ago

Motivation

Noticed that black wasn't being run in https://github.com/hdmf-dev/hdmf-zarr/actions/runs/7335433157/job/19973345812#step:4:66 , presumably because at the time of a PR the changes have already been committed, see https://pre-commit.com/#usage-in-continuous-integration

I assume it's intended to check if PRs are black-compliant? but isn't currently doing that. I ran a manual check of black and it looks like most of the package isn't either, so this will cause all other PRs to fail until upstream has been black reformatted.

How to test the behavior?

make new PR, make black-noncompliant changes, tests should fail.

Checklist

rly commented 8 months ago

After #153 and #146 have been merged, @mavaylon1 can you reformat the repo using black and push those changes in a separate PR?

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9692a98) 84.51% compared to head (5d974a4) 84.51%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #151 +/- ## ======================================= Coverage 84.51% 84.51% ======================================= Files 5 5 Lines 1104 1104 Branches 296 296 ======================================= Hits 933 933 Misses 115 115 Partials 56 56 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mavaylon1 commented 5 months ago

After #153 and #146 have been merged, @mavaylon1 can you reformat the repo using black and push those changes in a separate PR?

Sure thing