hdmf-dev / hdmf-zarr

Zarr I/O backend for HDMF
https://hdmf-zarr.readthedocs.io/
Other
7 stars 7 forks source link

Fix bug when exporting HDF5 datasets with unlimited dimension #155

Closed oruebel closed 6 months ago

oruebel commented 6 months ago

Motivation

Fix #154

When an HDF5 file contains datasets with unlimited dimensions, use of the hdmf.utils.get_data_shape method yields the wrong data shape because the functions looks at maxshape first. This leads to an error on export because Zarr cannot create a dataset with undefined dimensions.

How to test the behavior?

See #154

Checklist

codecov-commenter commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (71bfa6d) 85.07% compared to head (21d5a6d) 85.16%.

Files Patch % Lines
src/hdmf_zarr/backend.py 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #155 +/- ## ========================================== + Coverage 85.07% 85.16% +0.08% ========================================== Files 5 5 Lines 1146 1146 Branches 311 311 ========================================== + Hits 975 976 +1 + Misses 115 114 -1 Partials 56 56 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.