Add NWB file convert unit test

hdmf-dev / hdmf-zarr

Zarr I/O backend for HDMF

https://hdmf-zarr.readthedocs.io/

Other

7 stars 6 forks source link

Add NWB file convert unit test #161

Closed oruebel closed 7 months ago

oruebel commented 7 months ago

Motivation

Fix #160
Updated ZarrIO.get_type to resolve bytes dtype
Add test mixin to test rountrip conversion for a minimal NWB file
Updated

How to test the behavior?

pytest

Checklist

[x] Did you update CHANGELOG.md with your changes?
[X] Have you checked our Contributing document?
[X] Have you ensured the PR clearly describes the problem and the solution?
[X] Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
[X] Have you checked to ensure that there aren't other open Pull Requests for the same change?
[X] Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (300070b) 85.59% compared to head (9b2d2c9) 86.04%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #161 +/- ## ========================================== + Coverage 85.59% 86.04% +0.45% ========================================== Files 5 5 Lines 1159 1161 +2 Branches 295 296 +1 ========================================== + Hits 992 999 +7 + Misses 110 107 -3 + Partials 57 55 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oruebel commented 7 months ago

Do you think you oculd cut a 0.5.1 release with this fix?

Let me see what I can do. From a code perspective, I don't think there is anything in the way of making a release. I haven't done a release myself in a while, so let me see what I can do.

alejoe91 commented 7 months ago

Do you think you oculd cut a 0.5.1 release with this fix?

Let me see what I can do. From a code perspective, I don't think there is anything in the way of making a release. I haven't done a release myself in a while, so let me see what I can do.

Thanks! If that's not possible we'll pin our pipeline to the commit, but it would be great to pin a release version :)

oruebel commented 7 months ago

I'll see if I can cut release today and get back to you