hdmf-dev / hdmf-zarr

Zarr I/O backend for HDMF
https://hdmf-zarr.readthedocs.io/
Other
7 stars 7 forks source link

Update coverage call, don't install in editable mode in testing #188

Closed rly closed 2 months ago

rly commented 3 months ago

Motivation

Analogous to https://github.com/hdmf-dev/hdmf/pull/1107

https://setuptools.pypa.io/en/latest/userguide/development_mode.html says

Editable installs are not a perfect replacement for regular installs in a test environment. When in doubt, please test your projects as installed via a regular wheel. There are tools in the Python ecosystem, like tox or nox, that can help you with that (when used with appropriate configuration).

We use editable installs in testing in a couple places, mostly to help coverage find the sources, but we can configure that in pyproject.toml instead.

How to test the behavior?

Run all GitHub actions

Checklist

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.42%. Comparing base (5fd5c58) to head (5e64119).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #188 +/- ## ========================================== - Coverage 86.05% 84.42% -1.64% ========================================== Files 5 5 Lines 1162 1162 Branches 287 287 ========================================== - Hits 1000 981 -19 - Misses 107 126 +19 Partials 55 55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.