hdmf-dev / hdmf-zarr

Zarr I/O backend for HDMF
https://hdmf-zarr.readthedocs.io/
Other
7 stars 6 forks source link

Don't open with consolidated metadata in mode r+ #193

Closed mavaylon1 closed 6 months ago

mavaylon1 commented 6 months ago

Motivation

What was the reasoning behind this change? Please explain the changes briefly. Fix #182

The fix is to open without consolidated metadata when in mode r+.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.05%. Comparing base (07a5bb2) to head (5357b2e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #193 +/- ## ======================================= Coverage 86.05% 86.05% ======================================= Files 5 5 Lines 1162 1162 Branches 287 287 ======================================= Hits 1000 1000 Misses 107 107 Partials 55 55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mavaylon1 commented 6 months ago

Review Notes: I do not think a test is needed for this.