hdmf-dev / hdmf-zarr

Zarr I/O backend for HDMF
https://hdmf-zarr.readthedocs.io/
Other
7 stars 6 forks source link

Fix export cache spec and fix read cached spec #232

Closed rly closed 1 week ago

rly commented 1 week ago

Motivation

Fix #145. Cached extensions that are not one of {core, hdmf-common, hdmf-experimental} were not being exported into the Zarr store. In addition, cached extensions were not being read correctly because the name of the ZarrSpecReader source was being set to "./namespace" rather than something unique to the spec. The specs were also not being cached. This PR makes the code for ZarrSpecReader more aligned with H5SpecReader.

How to test the behavior?

Run example code in #145 but you need to use this branch in HDMF to read the file https://github.com/hdmf-dev/hdmf/pull/1205

Checklist

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.58%. Comparing base (049402f) to head (bbc4ecd).

Files with missing lines Patch % Lines
src/hdmf_zarr/backend.py 66.66% 0 Missing and 1 partial :warning:
src/hdmf_zarr/utils.py 88.88% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #232 +/- ## ========================================== - Coverage 85.67% 85.58% -0.10% ========================================== Files 5 5 Lines 1208 1214 +6 Branches 301 304 +3 ========================================== + Hits 1035 1039 +4 Misses 113 113 - Partials 60 62 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.