hdmf-dev / hdmf

The Hierarchical Data Modeling Framework
http://hdmf.readthedocs.io
Other
46 stars 24 forks source link

Field_config refactored #1094

Closed mavaylon1 closed 2 months ago

mavaylon1 commented 2 months ago

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

  1. We want to use the PyNWB typemap when using the TypeConfigurator in pynwb. As a result we need to update the field setter to take in typemap.
  2. I cleaned up the field_config method.

We can override the get type map function on the pynwb side.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.70%. Comparing base (d85d0cb) to head (53e6775).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1094 +/- ## ========================================== + Coverage 88.68% 88.70% +0.01% ========================================== Files 45 45 Lines 9740 9745 +5 Branches 2768 2767 -1 ========================================== + Hits 8638 8644 +6 - Misses 778 779 +1 + Partials 324 322 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.