Config Typemap generalize

hdmf-dev / hdmf

The Hierarchical Data Modeling Framework

http://hdmf.readthedocs.io

Other

46 stars 24 forks source link

Config Typemap generalize #1117

Closed mavaylon1 closed 1 month ago

mavaylon1 commented 1 month ago

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

This cleans up the typemap defaults in pynwb and hdmf when loading TypeConfig.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

[x] Did you update CHANGELOG.md with your changes?
[x] Does the PR clearly describe the problem and the solution?
[x] Have you reviewed our Contributing Guide?
[x] Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.72%. Comparing base (a497da3) to head (b7536bd).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1117 +/- ## ======================================= Coverage 88.71% 88.72% ======================================= Files 45 45 Lines 9760 9765 +5 Branches 2771 2773 +2 ======================================= + Hits 8659 8664 +5 Misses 779 779 Partials 322 322 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mavaylon1 commented 1 month ago

Review Notes:

The HDMF-Zarr tests are failing due to HDMF-Zarr issues. This is noted and being developed.
This PR is in support of PyNWB integration.