Expanding support for Append - Githubissues

hdmf-dev / hdmf

The Hierarchical Data Modeling Framework

http://hdmf.readthedocs.io

Other

46 stars 24 forks source link

Expanding support for Append #1126

Closed mavaylon1 closed 1 week ago

mavaylon1 commented 1 month ago

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

DatasetOfReferences (thoughts): Say I have a DatasetofReferences (that has been opened in append mode). I want to append to it. This DoR is the data of a VectorData. There are a few problems here.

There is no support in append_data for appending a DoR.
We also have two types of DoR classes, so we can get by this with a check of HDMFDataset.
Even with HDMFDataset there is no append method that will append to the data itself. This data would either be a H5 dataset or a zarr array.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

[ ] Did you update CHANGELOG.md with your changes?
[ ] Does the PR clearly describe the problem and the solution?
[ ] Have you reviewed our Contributing Guide?
[ ] Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?