hdmf-dev / hdmf

The Hierarchical Data Modeling Framework
http://hdmf.readthedocs.io
Other
46 stars 24 forks source link

Cannot write multi-dimensional string arrays #1137

Open rly opened 1 week ago

rly commented 1 week ago

This only works for 1-D string arrays. I think the if statement in this code is intended to check for structured arrays / compound dtypes. Else, execution should go to get_data_shape which gets the shape correctly.

https://github.com/hdmf-dev/hdmf/blob/7426275cacc769a10ffca89836765df1355ba9db/src/hdmf/backends/hdf5/h5tools.py#L1472-L1473