hdmf-dev / hdmf

The Hierarchical Data Modeling Framework
http://hdmf.readthedocs.io
Other
46 stars 24 forks source link

Move scipy to optional requirements #1140

Open rly opened 1 week ago

rly commented 1 week ago

Motivation

scipy is used only by the CSRMatrix data type, which is currently rarely used. To reduce the chance of dependency conflicts and reduce the install time, I propose we make scipy an optional requirement.

This is a breaking change since users using the CSRMatrix type will need to install scipy separately.

Merging into new hdmf_4.0 branch.

Checklist

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.79%. Comparing base (539ecf4) to head (7942faa). Report is 2 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1140 +/- ## ========================================== + Coverage 88.78% 88.79% +0.01% ========================================== Files 45 45 Lines 9778 9790 +12 Branches 2777 2779 +2 ========================================== + Hits 8681 8693 +12 Misses 780 780 Partials 317 317 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.