search

hdmf-dev / hdmf

The Hierarchical Data Modeling Framework
http://hdmf.readthedocs.io
Other
46 stars 26 forks source link

[Feature]: Avoid clearing builder cache if possible #867

Open rly opened 1 year ago

rly commented 1 year ago

What would you like to see added to HDMF?

See https://github.com/hdmf-dev/hdmf/pull/866

Currently we clear the builder cache in order to rebuild all the builders and write these rebuilt builders with {"link_data": False} when exporting. This seems unnecessary and resulted in a string encoding error when roundtripping between Zarr and HDF5: https://github.com/hdmf-dev/hdmf-zarr/issues/79

Can we solve this issue https://github.com/hdmf-dev/hdmf/issues/842 without clearing the builder cache?

Is your feature request related to a problem?

No response

What solution would you like?

see above

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

mavaylon1 commented 1 year ago

@rly When we get ZarrIo up to speed with hdmf, the clearing of the cache shouldn't be an issue. However, it still might not be the best idea. I will keep this on our radar and ping this to you for an alternate solution since you had the original ticket.