search

hdoro / sanity-plugin-external-files

Work w/ media hosted in external vendors from inside a Sanity.io studio
44 stars 14 forks source link

(#4) Added option to Include File URL in schema. #5

Open KyleSmith0905 opened 2 years ago

KyleSmith0905 commented 2 years ago

In response to the issue I made (#4):

I added a potential option that allows the File URLS to be removed from the schema, the Firebase DAM, for example, came with an authorization token in the URL that allows anyone to view it despite the rules set. I've only edited the Firebase DAM to have the option to include File URL.

I couldn't test this on a running sanity website, though I plan to try on Monday.

This is a small, non-breaking change.

I'm open for suggestions. Also, I should also add a guide on README.md about the new option.

KyleSmith0905 commented 2 years ago

Just using it now, I have more stuff to do since it's not working the best. There was a typing error and the options wasn't getting passed down, I fixed both of them, but I just stumbled on another error.

KyleSmith0905 commented 2 years ago

I want to preface that this is not ready to merge. I just need a go-ahead before I spend some time to patch up this pull request.