Closed nkgentile closed 2 years ago
Thank you for the work, Noah! I'm yet to run it locally for manual testing, but it looks polished and ready to go - sorry for the messy code you had to go through 🙈
I won't have time for a thorough review until next week - in the meantime could you:
*
(i.e. everything)?Anywho, don't want to give you too much extra work, you're already rocking - thanks again!
No worries! I tried to be as surgical as I could be to prevent any confusion when reviewing. And yes, please test yourself to make sure I didn't accidentally create any bugs, especially in the other DAM plugins.
I can definitely look into these two changes and update this PR:
DEFAULT_ACCEPT
value changes? Would changing the default toolTitle
fall under this as well?
Description
defaultAccept
andtoolTitle
as plugin configuration options. For example:config/s3-dam.json
uploadMachine
as a fallbackMediaPreview
component's internal logic to accommodate more file types.Type of change