search

hdragomir / facetogif

face to gif is a simple webapp that lets you record yourself and gives you an infinitely looping animated gif
https://hdragomir.github.io/facetogif/
MIT License
476 stars 53 forks source link

IMGUR Upload Function #4

Closed craftfortress closed 11 years ago

craftfortress commented 11 years ago

Path is built incorrectly - points to http://imgur.com/undefined.

Not sure if this is because the image upload failed.

hmmm seems to only occur if your GIF is too large? I took a 10 second gif and it failed. Perhaps we need to check if it has uploaded successfully?

hdragomir commented 11 years ago

Hi, @craftfortress.

As you said, this is because there is a silly little 2MB limit on gifs on imgur. The easy workaround is to download the gif and use one of the many optimisers out there. I already do suggest that below, in the faq.

Creating optimised gifs to begin with is one of gif.js priorities, as far as I understand.

For now, the patch I made in #3 - which is to tell you it would fail and not let you try at all - is in.

craftfortress commented 11 years ago

Thank you for the quick amendment and feedback = )

On 28 June 2013 00:15, Horia Dragomir notifications@github.com wrote:

Hi, @craftfortress https://github.com/craftfortress.

As you said, this is because there is a silly little 2MB limit on gifs on imgur. The easy workaround is to download the gif and use one of the many optimisers out there. I already do suggest that below, in the faq.

Creating optimised gifs to begin with is one of gif.js priorities, as far as I understand.

For now, the patch I made in #3https://github.com/hdragomir/facetogif/issues/3- which is to tell you it would fail and not let you try at all - is in.

— Reply to this email directly or view it on GitHubhttps://github.com/hdragomir/facetogif/issues/4#issuecomment-20161363 .