hdresearch / nolita

Work with web-enabled agents quickly — whether running a quick task or bootstrapping a full-stack product.
https://nolita.ai
MIT License
79 stars 3 forks source link

browserUtils: check for chromepath #100

Closed matildepark closed 2 weeks ago

matildepark commented 2 weeks ago

We actually see if ChromePath is there before passing it to Puppeteer (which falls back to its own installation).

I think that in Linux cases, if you have google-chrome-stable installed then it causes some sort of clobber case. chrome-paths outsources its logic to another package (lol) which tries to run it in context which then isn't available to our Puppeteer context. Why? I don't know, really, it comes down to what user a command runs as. If we just passed /usr/bin/google-chrome it would work. Instead we pass google-chrome and it crashes once Puppeteer gets that path.

What I inadvertently learned is that because we use chrome-paths we also support Chromium and Canary, since that's what Karma Chrome Launcher looks for.