search

hdresearch / nolita

Work with web-enabled agents quickly — whether running a quick task or bootstrapping a full-stack product.
https://nolita.ai
MIT License
79 stars 3 forks source link

bin: rewrite around page instances #86

Closed matildepark closed 4 weeks ago

matildepark commented 1 month ago

Retains current functionality, rewritten around Pages.

Question: do we return objectiveFailed ever? The error state appears to exist in agentBrowser.ts but not in page.ts, and we just bail out without throwing an error. Do I just have to see if we're out of iterations and throw manually?

AlephNotation commented 1 month ago

We can go add that error back in. Would it be helpful?

matildepark commented 1 month ago

We can go add that error back in. Would it be helpful?

I was just understanding if there was a reason (like if it introduced weird edge cases or w/e). Is there a quirk that happens if we specify a step where we return a failed objective browse? Or is it more ergonomic to give no feedback? The last thing we get is the final step it attempts before it returns.

AlephNotation commented 1 month ago

Mostly its an artifact of not wanting to make the return type messier. But I think it would provide better dev ergonomics so I will add it back in

AlephNotation commented 4 weeks ago

added the failure case

matildepark commented 4 weeks ago

Test failed on one item because it expects an objective complete type, and the objective failed in the test. Merging into dev.