search

hdumcke / minipupper_ros2

Other
6 stars 0 forks source link

Make ROS2 installation configurable #2

Open sskorol opened 2 years ago

sskorol commented 2 years ago

Hi, I started digging into scripts and found you use ROS Galactic everywhere. I believe it'd make sense to make it configurable assuming the fact minipupper_base supports both 20.04 and 22.04 versions. Users may want to use ROS Foxy on Focal or Humble on Jemmy. So instead of walking through scripts and fixing the paths, it'd be nice to control the installation via the env variable for example.

hdumcke commented 2 years ago

minipupper_base support Ubuntu 20.04 and 22.04. But as I currently focus on kinematics I am not making the changes you have proposed right now. But if you want to send a pull request I'd be happy to review & merge