search

hdus / SRTM-Downloader

GNU General Public License v3.0
28 stars 5 forks source link

[FIX] #27 by check list contains element #28

Closed Input-BDF closed 10 months ago

Input-BDF commented 11 months ago

seems to affect large area downloads, caused by missing (/maybe prior) removed reply elements

hdus commented 11 months ago

Please create a pull request.

Input-BDF commented 11 months ago

Sorry for my lack of explanation, I was a little bit in a hurry. This pull request should fix #27 which seems to occure if there are a lot of srtm-tiles requested. For some reasons (which I could not fully debug yet) there are situations, where the reply seems not to be added to self.reply_list of Downloader class or is in some way removed before QNetworkAccessManager.finished signal is emitted.

Hence removing a element from a list not containing it will raise a NameError-exception (line 119 of download.py). One way to handle this is check the list if the element to be removed even exists within the list or the NameError-Exception should be catched in a better way.

Edit: Just realized, that my second element check in Download.abort_reply() function isn't really necessary. But it will not harm

Meepokie commented 10 months ago

Hi, thanks for the FIX! I've made the edits mentioned above, in the download.py but I'm still getting "ValueError: list.remove(x): x" not in list error on line 119. Is there anything else I can try? Thank you so much!

Input-BDF commented 10 months ago

Hi, thanks for the FIX! I've made the edits mentioned above, in the download.py but I'm still getting "ValueError: list.remove(x): x" not in list error on line 119. Is there anything else I can try? Thank you so much!

Please verify, that you made the changes within function reply_finished() or download download.py if you havn't checked out the repo. And maybe restart Qgis (to reload everything). If reply is not member of the list by a timing issue, it should at least throw the exception now in line 122

hdus commented 10 months ago

I have published the fixed version 3.2.1at the official QGIS Plugin Repository. Please give it a try.