search

hdus / pg_raster_upload

QGIS plugin for uploading raster data to a PostGIS database.
GNU General Public License v2.0
5 stars 3 forks source link

Dialog for creating overviews and some other small improvements #13

Closed effjot closed 1 year ago

effjot commented 1 year ago

As suggested in issue #10, this is a PR introducing a new dialog for adding overviews for already existing rasters. The PostGIS raster has to be loaded into QGIS and then could be selected for raster creation. Maybe we could offer a option for the user to select which overview levels would be created. At the moment it uses the default of 2 – 256.

Before writing the create overviews dialog, I fixed some minor issues with the DB connections and added protection against importing rasters without CRS. These are also included in this PR. If this is inconvenient, I could move these to a separate PR.

hdus commented 1 year ago

Your work looks great, thanks for that!

I have two points that should be added:

  1. the new icon should still have an indication that it is a new database raster. Please integrate a database symbol additionally into the icon.

  2. it would also be cool if the new function with the pyramid icon is integrated into a ToolButtonMenue. This way we would have only one icon for the plugin and the toolbar would be tidier.

Could you also make this?

effjot commented 1 year ago

My drawing skills aren’t great, I just mashed together pieces from two SVG files. But I can give it a try.

If I understand you correctly, there would be only one button in the database toolbar from which the two actions (import and create overviews) would pop up?

effjot commented 1 year ago

Maybe we could also consider adding the overviews code to the general QGIS toolbox algorithm gdal:overviews.