search

hdus / pg_raster_upload

QGIS plugin for uploading raster data to a PostGIS database.
GNU General Public License v2.0
5 stars 3 forks source link

Don’t reset schema selection on upload (fix issue #4 regression) #6

Closed effjot closed 1 year ago

effjot commented 2 years ago

I’ve factored out updating the schema combobox from init_DB(), so that init_DB() can safely used repeatedly, esp. in on_btn_upload_clicked().

The return None statements in init_DB are changed to return None, None in order to have a uniform return type (2-element tuple) for all cases. Thus, the return value can be safely unpacked (avoiding cannot unpack non-iterable NoneType object errors) and connection success checked.

I hope the schema selections now finally works.

I also added a little information about table name laundering to README.md.

effjot commented 2 years ago

I think we’ve been working on the code at the same time. Should I try to rebase this PR on your current master?

effjot commented 1 year ago

I think the changes in this PR have been implemented in master already.