he-dhamo / graphto3d

Code for ICCV 2021 paper Graph-to-3D: End-to-End Generation and Manipulation of 3D Scenes using Scene Graphs
Apache License 2.0
59 stars 12 forks source link

Dataset bug #18

Closed caixiaoniweimar closed 1 year ago

caixiaoniweimar commented 1 year ago

Hi Helisa,

thanks for the amazing work. I found there might be a bug here: https://github.com/he-dhamo/graphto3d/blob/12e352078ba48327f4bedde86f4b0b07d963e548/dataset/dataset.py#L489 obj_points[i] = obj_pointset should be inside the for-schleife. Otherwise, it can only learn one shape of a scene,right? Please correct me if I misunderstood. Thanks,

Regards, Cai.

he-dhamo commented 1 year ago

Hi Cai, well spotted, thanks for letting us know. We always used the option with_feats = True for our paper, therefore we didn't notice this bug in the code release.