he7d3r / mw-gadget-LanguageConverter

Other
0 stars 0 forks source link

Menu labels are wrong with the Vector skin #1

Closed Seudo3 closed 7 months ago

Seudo3 commented 1 year ago

Hello, When using the gadget at the French Wikisource (and probably on other Wikisources), the four menu entries have all the same label after converting the language. For example:

If I'm correct, the bug is at line 582 in LanguageConverter.js : the selector should be $( '#p-cactions-label' ) (which only includes the menu title), not $( '#p-variants-js' ) (which also includes the entries inside the menu).

This bug appears in Vector 2010 and Vector 2020, not in Monobook (because Monobook does not use spans here, so this line produces no effect).

he7d3r commented 7 months ago

Fixed by https://github.com/he7d3r/mw-gadget-LanguageConverter/commit/61b312d972db4086d837514802e0c309275425c0. Thank you for reporting!