search

headbase-app / headbase

The customizable database for your brain. Note-taking, task-management, personal knowledge bases and more.
https://headbase.app
GNU Affero General Public License v3.0
1 stars 0 forks source link

Intermittent tab/browser crash when using popups #2

Closed ben-ryder closed 2 years ago

ben-ryder commented 2 years ago

When using popups or opening modals, every now and again these actions will completely crash the browser and/or current tab. There are no JS errors or anything - as far as I can see - everything just crashes. After a few refreshes or random code changes the issues then go away.

This effects both the dev server and production builds of the app, and looks to be an issue across devices

ben-ryder commented 2 years ago

My suspicion is this is either redux or headlessui modal related, as the error only seems to happen when an action is taken in the popup (such as trying to create a note which will dispatch and action and open the create content modal).

ben-ryder commented 2 years ago

This is now fixed. After a refactor there was a close() call left in the code (which once upon a time was a function provided by headlessui, but after the refactor it was then calling the browser level close function 🤦 )