search

headintheclouddev / typings-suitescript-2.0

TypeScript typings for SuiteScript version 2.0
MIT License
142 stars 89 forks source link

Internal imports shouldn't use "N/..." module names #252

Closed bendemeyer closed 11 months ago

bendemeyer commented 11 months ago

Most of the files in the N directory refer to each other using relative paths, but in a few places they use N/somename instead. There's no advantage to doing this, as far as I can tell, but it does break any projects that might want to use these types without changing their TypeScript config to point those paths at this project (for example, using both this project and the official NetSuite unit testing stubs library).

I think I've identified all the cases where this happens already, so if this is a desired change I can open a PR for it.

bendemeyer commented 11 months ago

I looked at this again and realized it was pretty small so I just went ahead and created a PR: https://github.com/headintheclouddev/typings-suitescript-2.0/pull/253/files

MrRob commented 11 months ago

Merged, thank you!