search

headlamp-k8s / headlamp

A Kubernetes web UI that is fully-featured, user-friendly and extensible
https://headlamp.dev
Apache License 2.0
2.22k stars 156 forks source link

Use a proper check in the backend for knowing Headlamp is in desktop #1096

Closed joaquimrocha closed 10 months ago

joaquimrocha commented 1 year ago

We are using !in-cluster to indicate we are in the desktop version, but while this works in most cases, it's not a very direct check and an override of this flag can have implications if Headlamp is hosted with in-cluster=false.

So let's add a proper check for whether we are in-desktop. Otherwise, we can also add feature flags for each feature we're restricting to in-desktop.

joaquimrocha commented 10 months ago

We have moved the features like dynamic-clusters to their own flags, so this issue is no longer valid IMO.