Alternative methods to provide OIDC configuration

headlamp-k8s / headlamp

A Kubernetes web UI that is fully-featured, user-friendly and extensible

https://headlamp.dev

Apache License 2.0

2.22k stars 156 forks source link

Alternative methods to provide OIDC configuration #1160

Closed maxsargentdev closed 1 year ago

maxsargentdev commented 1 year ago

Hi,

I have noticed that the only way to provide the OIDC configuration (which some of is sensitive) is directly in the values file.

It would be good to be able to support loading this configuration from environment variables or files. If you are using a GitOps approach for managing your deployment of headlamp the current setup forces you into bad practice.

Is this a welcome change? If so I will make it.

Thanks, Max Sargent

maxsargentdev commented 1 year ago

I did not read enough of the source, I have found the HEADLAMPCONFIG prefix now, thanks.

maxsargentdev commented 1 year ago

Re-opening, this change will now be a request for:

Trivial change to the helm chart to support setting environment variables from a secret
Updating the koanf usage so that it can read the settings from a flat yaml file mounted at a pre-specified location

Thanks.

joaquimrocha commented 1 year ago

Thanks @maxsargentdev . We will look into this.