Plugins are not disabling correctly

headlamp-k8s / headlamp

A Kubernetes web UI that is fully-featured, user-friendly and extensible

https://headlamp.dev

Apache License 2.0

2.22k stars 156 forks source link

Plugins are not disabling correctly #1760

Closed knrt10 closed 7 months ago

knrt10 commented 7 months ago

Setup

Run headlamp in-cluster or locally.
Go to plugin settings http://localhost:3000/settings/plugins
Click on toggle button to disable plugins

Expected behaviour

Plugin should be disabled

Actual behaviour

Plugin still works

Screenshot

cc @yolossn

yolossn commented 7 months ago

When the Save and Apply button is clicked after enabling/disabling a plugin the values is getting changed in localStorage and redux as expected. But still the plugin is loading, looks like a pre existing issue cc: @vyncent-t @illume

illume commented 7 months ago

Plugins should only be able to be disabled in app mode. Not in-cluster. The UI should not be available out of app mode, so I'll fix that.

I confirmed it works in app mode.

illume commented 7 months ago

Added a fix in https://github.com/headlamp-k8s/headlamp/pull/1570