headlamp-k8s / headlamp

A Kubernetes web UI that is fully-featured, user-friendly and extensible
https://headlamp.dev
Apache License 2.0
2.22k stars 156 forks source link

frontend not updating when plugins change, when opencost plugin installed #2196

Open illume opened 2 months ago

illume commented 2 months ago

Currently in main the frontend is not updating when a change is made in a plugin, when the opencost plugin is installed.

Note: ideally no plugin should be able to stop the other ones loading when in development... so this should ultimately be fixed in the frontend/.

impact

The impact is the developer experience is severely reduced. But only if the opencost plugin is installed.

How to reproduce

illume commented 2 months ago

Installing the opencost plugin causes it to stop working.

I don't think it's a regression. I had the same broken behaviour with an earlier version of Headlamp 0.24.1.

sniok commented 2 months ago

I can't seem to reproduce it. I installed opencost plugin, then npm start of kompose plugin and app is reloaded on every change in the kompose plugin. (0.24.1 and 0.25 rc)

illume commented 2 months ago

Thanks for testing it @sniok

I wonder how you installed the opencost plugin? I installed it with npm start from the plugins repo main branch.

sniok commented 2 months ago

I tried installing it both from plugin catalog and from npm start. Same outcome

illume commented 2 months ago

Probably we should not block the release on this issue. Because the impact won't be so large. Only those making plugins who also install opencost plugin will be affected (and not everyone even then).

I'll move this to the next release milestone.

cc @joaquimrocha

joaquimrocha commented 1 week ago

cc/ @vyncent-t

joaquimrocha commented 9 hours ago

New tip: We need to review the hooks, after testing the latest version. cc/ @knrt10