"Something went wrong" alert needs some work

headlamp-k8s / headlamp

A Kubernetes web UI that is fully-featured, user-friendly and extensible

https://headlamp.dev

Apache License 2.0

2.27k stars 160 forks source link

"Something went wrong" alert needs some work #2314

Closed sniok closed 1 month ago

sniok commented 2 months ago

Tested on 0.25.1, disabled the network and this is how it looks like

On wide screens it's way too short

Medium screens, covers the logo

On narrow screens, padding pushes the content all the way to the right

This seems like a good component to use

https://mui.com/material-ui/react-alert/

sniok commented 2 months ago

Also I think the message should be "Lost connection to the cluster" because it checks if the browser is online or if healthz endpoint of a cluster responds.

skoeva commented 2 months ago

+1 this banner has been really buggy and the message isn't at all visibly traceable to the issue

skoeva commented 1 month ago

Got around to checking out the alert component, looks promising. We can keep the width at 100% as before, but I think it would be cleaner and more convenient if the alert was a bit smaller (maybe something closer to this):

@sniok WDYT?