search

headlamp-k8s / headlamp

A Kubernetes web UI that is fully-featured, user-friendly and extensible
https://headlamp.dev
Apache License 2.0
2.22k stars 156 forks source link

storybook brokenness #2450

Open illume opened 3 days ago

illume commented 3 days ago

Describe the bug

List views are broken in storybook.

image

To Reproduce

npm start storybook

Go to node list.

Environment (please provide info about your environment):

Are you able to fix this issue?

maybe

Additional Context

Related to:

With the switch to vite it seems some of these started failing.

illume commented 1 day ago

More info from @skoeva about this here: https://github.com/headlamp-k8s/headlamp/pull/2451#issuecomment-2423087309

  • Loading the storybook home (http://localhost:6006) usually does not cause any components to fail. Even in main, once the home view opens, you can click around, and even the List test does not fail.
  • Loading a component in storybook (i.e. http://localhost:6006/?path=/story/resource-maininfosection--null-backlink) and refreshing on this page will eventually cause storybook to fail with similar messages to what you've posted, both in main and the node-story branch. This isn't unique to List though, I've attached some sample screenshots below.
sniok commented 1 day ago

This error is cause by circular imports, temp workaround is to always start from the home