headlamp-k8s / headlamp

A Kubernetes web UI that is fully-featured, user-friendly and extensible
https://headlamp.dev
Apache License 2.0
2.22k stars 156 forks source link

Fix the 10 warnings when compiling the frontend #557

Open joaquimrocha opened 2 years ago

joaquimrocha commented 2 years ago

Description

Since the recent CRA changes, there are 10 warnings when compiling the frontend.

Impact

While these are just warnings, they make a lot of noise and look broken to developers, so we should fix them.

Environment and steps to reproduce

  1. Run make run-frontend

Expected behavior

No warnings should be shown on a clean main checkout.

Current behavior

10 warnings are shown:

[9 more before this one]...
WARNING in ./node_modules/@jsdevtools/ono/esm/types.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/jrocha/headlamp/frontend/node_modules/@jsdevtools/ono/src/types.ts' file: Error: ENOENT: no such file or directory, open '/home/jrocha/headlamp/frontend/node_modules/@jsdevtools/ono/src/types.ts'
 @ ./node_modules/@jsdevtools/ono/esm/index.js 4:0-24 4:0-24
 @ ./node_modules/@apidevtools/swagger-parser/lib/index.js 10:16-42
 @ ./src/lib/docs.ts 6:0-50 12:9-28
 @ ./src/components/common/Resource/DocsViewer.tsx 15:0-50 54:4-21
 @ ./src/components/common/Resource/EditorDialog.tsx 29:0-38 361:45-55
 @ ./src/components/common/index.ts 24:0-40 24:0-40 25:0-66 25:0-66
 @ ./src/i18n/ThemeProviderNexti18n.tsx 10:0-46 58:68-74
 @ ./src/App.tsx 13:0-65 40:35-56
 @ ./src/index.tsx 6:0-24 9:38-41

10 warnings have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.
illume commented 2 years ago

The dependency this uses fell out of maintenance for several months (last I looked). Rather that drop the feature this is used for (a documentation feature), I'll look into a replacement first. If there's nothing suitable then we can look into making a patch (which we can use with our patch setup).