search

headlamp-k8s / headlamp

A Kubernetes web UI that is fully-featured, user-friendly and extensible
https://headlamp.dev
Apache License 2.0
2.22k stars 156 forks source link

[RFE] Ship Headlamp's source code in headlamp-plugin #778

Closed joaquimrocha closed 1 year ago

joaquimrocha commented 2 years ago

Current situation

If a plugin wants to add tests with e.g. Storybook, then the integration fails because the headlamp-plugin package doesn't actually ship the source code, just the typings and webpack magic used to be able to compile the plugin as a lean bundle (not packing all the source code).

Not shipping the source code also prevents plugins to use testing like Storybook if they use any of Headlamp's components (which they most likely do).

Ideal future situation

Not shipping the source code has had an impact in things like IDE integration, readability, etc. which we have managed to tame before, but at this point it seems like it'd be a good idea to just ship the source code for Headlamp in a structure that matches the current headlamp-plugin's type integration, and still make sure that when the production bundle is created, it will use external modules instead of the compiled Headlamp source code.

joaquimrocha commented 1 year ago

@illume , Should we close this one? (If not please add it to the 0.15.0 milestone)

joaquimrocha commented 1 year ago

This is done now and pre-released in headlamp-plugin ATM.