headlamp-k8s / plugins

Official plugins of the Headlamp project
https://headlamp.dev/
Apache License 2.0
13 stars 2 forks source link

frontend: Add CNCF and verification badge to charts #42

Closed vyncent-t closed 5 months ago

vyncent-t commented 5 months ago

Enhance App Catalog with ArtifactHub Badges

Description

fixes issue #20

This PR aims to enhance our app catalog by incorporating important badges from ArtifactHub. These badges indicate whether an app is official, verified, or a CNCF project. Displaying these badges will help users make informed decisions about which packages to install, ensuring they opt for secure and verified applications.

Changes

Verification

Images

image

illume commented 5 months ago

@vyncent-t from our discussions...

We were looking at showing the "not verified states" too. image

Notice the extra description, explaining what exactly each of the badges means https://artifacthub.io/packages/helm/nginx-gateway-fabric/nginx-gateway-fabric

Additionally, perhaps sharing the iconography as artifact hub will make it easier for users. So they can reuse that knowledge of what icon is what?

vyncent-t commented 5 months ago

I updated the visuals to match those of artifact hub with matching labels for non verified and others @illume

image

sniok commented 5 months ago

Is it just me or does it look a bit too "busy"? A lot of different colors makes it a bit hard to parse visually. What if we kept the icons only when the app is "verified", "official", etc and kept them monochrome at all times? Something like this:

image

doesn't have to be changed within this PR, we can discuss and iterate later

joaquimrocha commented 5 months ago

I agree with @illume that we should keep the icons aligned with ArtifactHub, meaning that a star would be for official, and a check mark for verified, but we can use different icons and in the monochromatic version as @sniok said. The important thing is to make sure users can have direct access to an official Nginx chart, before they even see any unofficial versions. That's why the sorting is so important.

In a different PR we should also not show unofficial charts unless the user specifically toggled a switch to include those in the plugin settings.

vyncent-t commented 5 months ago

Made some slight changes with the monochrome as the dark mode CNCF Icon isnt exactly easy to see as its an image and not an icon

Dark & Dark mode

image

Color & Dark mode

image

image

vyncent-t commented 5 months ago

noticed in some places artifact hub will use either chart.cncf or chart.repository.cncf on their icons to choose to display so I implemented that

joaquimrocha commented 5 months ago

I have reduced the size of the cncf icon slightly + made the official badge appear first, as we had chatted (most important to least important).