search

headless-studio / leptos-leaflet

MIT License
25 stars 16 forks source link

feat: Added parameter bring_to_front and bring_to_back to tile layer and tile layer wms component #30

Closed emirror-de closed 5 months ago

emirror-de commented 5 months ago

I am not sure wether adding log as additional dependency fits your requirements, but I always find it very useful to add as much information as possible to the log for debugging purposes and bug findings.

But I am also happy to remove this dependency again if desired.

dgsantana commented 5 months ago

I don't mind the use of log crate, but prefer tracing crate (mostly do backend and mobile/desktop apps), which can add much more interesting information if some one wants. For simple logging, leptos already as that included. If you could switch to the leptos::logging::warn! which does the same thing, and avoids adding a extra crate. Thank you for the PR.

emirror-de commented 5 months ago

Thanks for the hint! I updated the branch accordingly.

dgsantana commented 5 months ago

Thanks again for the PR @emirror-de.