Closed dillingham closed 2 years ago
Currently an email is sent with the failures.. lets also add an email when it does not fail.
Subject:$count successfully imported
$count successfully imported
Content:Here is confirmation that $count rows have been imported successfully
Here is confirmation that $count rows have been imported successfully
Lets add this and the failure email inside a $importable->confirmation()
$importable->confirmation()
That way if someone overrides the import class, they can override that too.
Instead of adding an email assertion to the existing successful import test..
Lets duplicate it as its own test with the method name as test_import_confirmation_email
test_import_confirmation_email
And just assert the email outcome
Currently an email is sent with the failures.. lets also add an email when it does not fail.
Subject:
$count successfully importedContent:
Here is confirmation that $count rows have been imported successfullyLets add this and the failure email inside a
$importable->confirmation()That way if someone overrides the import class, they can override that too.
Instead of adding an email assertion to the existing successful import test..
Lets duplicate it as its own test with the method name as
test_import_confirmation_emailAnd just assert the email outcome