headmelted / codebuilds

Community builds of Visual Studio Code for Chromebooks and Raspberry Pi
https://code.headmelted.com
MIT License
1.03k stars 56 forks source link

GPG key doesn't download due to lack of curl following redirects #63

Open diablodale opened 5 years ago

diablodale commented 5 years ago

Download of GPG key in apt.sh for the APT install will fail given the current packagecloud.io infrastructure. This is due to the url https://packagecloud.io/headmelted/codebuilds/gpgkey issuing a redirect to the eventual location and unfortunately apt.sh does not use curl in a manner that will follow redirects.

The fix is to change line 28 of the script from:

curl $gpg_key | gpg --dearmor > /etc/apt/trusted.gpg.d/${REPO_VENDOR}_vscode.gpg;

to

curl -L $gpg_key | gpg --dearmor > /etc/apt/trusted.gpg.d/${REPO_VENDOR}_vscode.gpg;

This could be related to the multiple GPG problems like in issue #61

ZimbiX commented 4 years ago

This issue can now be closed as it's been resolved in 38e4efe.