Open Silerra opened 4 years ago
I'd suggest two things are missing - ensuring the https apt transport layer and dependencies are present - as I had to install apt-transport-https
on the (admittedly older) xenial aarch64 image I'm running... as well as how the key is loaded. Maybe just use the process used for installing Docker CE... tried and tested? Doing so would close those issues, and probably a few more, especially if switching to curl for everything.
Update the apt package index:
$ sudo apt-get update
Install packages to allow apt to use a repository over HTTPS:
$ sudo apt-get install \
apt-transport-https \
ca-certificates \
curl \
gnupg-agent \
software-properties-common
Add Docker’s official GPG key:
$ curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add -
I'd suggest two things are missing - ensuring the https apt transport layer and dependencies are present - as I had to install
apt-transport-https
on the (admittedly older) xenial aarch64 image I'm running... as well as how the key is loaded. Maybe just use the process used for installing Docker CE... tried and tested? Doing so would close those issues, and probably a few more, especially if switching to curl for everything.Update the apt package index: $ sudo apt-get update Install packages to allow apt to use a repository over HTTPS: $ sudo apt-get install \ apt-transport-https \ ca-certificates \ curl \ gnupg-agent \ software-properties-common Add Docker’s official GPG key: $ curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add -
I honestly don't understand your answer. Why should I suddenly use Docker? In addition, the problem doesn't appear in other applications installed via https.
I mean:
use the process used for installing Docker CE
i.e.
The only change that needs to be made from their pre-installation steps would be to use headmelted's GPG key... that's it.
It looks like we're talking past each other.
- ensure package index has been updated
Yes, I had forgotten that. But that doesn't change the real problem.
- ensure required packages are installed - apt-transport-https, curl, ca-certificates, etc
The packages apt-transport-https, curl, ca-certificates already existed.
- install GPG key properly through apt-key
That I already know that. And I had already mentioned that:
I know how to update the GPG file. But that can be a stumbling block for some others.
That doesn't pose a problem for me. I'm writing my own script to work around the problem.
I'm only interested if you follow the Apt instructions on the website https://code.headmelted.com/ on new, clean Raspbian installation, then that exactly this problem occurs.
I would be happy to test again on freshly set up Raspberry Pi if this is necessary for the troubleshooting.
Just saw this - will get a look at this tonight when I'm at my desk and try to get this corrected.
Lol... I think it's more a case not seeing the forest and focusing on the one tree :-P
If you actually 👀 at the apt.sh
file... most of what I said will make sense...
Package update and dependency installation (1 & 2) should go here up are around line 8 to ensure ALL systems, including those with out of date package index, have necessary dependencies. If yours is up to date, this will run through quickly, and won't do any thing.
https://github.com/headmelted/codebuilds/blob/38e4efe8994f2325d6474854e1c2a125d68ec183/docs/installers/apt.sh#L8-L9 https://github.com/headmelted/codebuilds/blob/38e4efe8994f2325d6474854e1c2a125d68ec183/docs/installers/apt.sh#L59-L60
Could even make it more intelligent, and only try to install missing dependencies...
And this gets replace with the apt-key line...
It's not a matter of
I know how to update the GPG file.
... it's a matter of ... it's an install script... it should do it's job, not need the end user to go fixing up stuff it didn't do properly. Not all the end users know how to do things like update the GPG file, and shouldn't be expected to.
Agree with @pfeerick that the script should work regardless of the current state of the machine. Will try to get a commit for this later today.
Incidentally, pull requests always welcome!! 😁
Well, since you mention that @headmelted ... #93 was born ;) It's still an untested WIP, but should more clearly show my line of reasoning (or irrationally? :laughing: ), and help focus the discussion.
It starts normally. But after the establishment of code-oss, another update process will be started during the update process. That's crazy. But this problem has been around some time. Well, the real problem is that the GPG file is empty after the entire installation routine. Updates can then no longer be made from headmelted repo. I know how to update the GPG file. But that can be a stumbling block for some others.
Here the terminal output:
The following issues can then be closed: #20, #63, #71 and perhaps #76 (The last one is a suggestion that has been implemented on packagecloud, but not in the file apt.sh)