headmyshoulder / odeint-v2

odeint - solving ordinary differential equations in c++ v2
http://headmyshoulder.github.com/odeint-v2/
Other
341 stars 101 forks source link

lorenz_parameters.cu possible typos? #227

Open tactmaster opened 6 years ago

tactmaster commented 6 years ago

Hello

Sorry I am new to using odeint, so this might be my mistake, however: should line https://github.com/headmyshoulder/odeint-v2/blob/master/examples/thrust/lorenz_parameters.cu#L85 m_beta.begin() ,

be m_beta.end() ,

as it is the 2nd argument of thrust::for_each?

Also should the parameter that is being varied in the parameter scan be R and not b (beta) here: https://github.com/headmyshoulder/odeint-v2/blob/master/examples/thrust/lorenz_parameters.cu#L55

If I am wrong, I would like to know how I have misunderstood this. Thanks.