headshot2017 / teeware-mod

Teeworlds mod with WarioWare style gameplay
Other
13 stars 11 forks source link

rebase on top of ddnet #4

Open bretonium opened 3 years ago

bretonium commented 3 years ago

From my experience supporting a mod for teeworlds, it is much much easier to have the whole git repo branched from the upstream DDNet, not copied. This way it will be easier to port it to further versions of DDNet, change protocols (if they get changed again) and use bugfixes.

Please consider rebasing your work on top of current DDNet master

def- commented 3 years ago

That would also allow seeing further when zooming out as a spectator, would allow showing 32 players properly in server browser in client.

bretonium commented 3 years ago

Please consider rebasing your work on top of current DDNet master

Actually, when i wrote that, i thought that the initial checked in version was on top of DDNet master. Given that the mod is made on top of DDNet 9.x, maybe it could be rebased on 9.x as a first step.