headspinio / appium-tizen-tv-driver

A Samsung Tizen TV driver for Appium
Apache License 2.0
10 stars 2 forks source link

enable autodownlaod capability #572

Closed KazuCocoa closed 4 months ago

KazuCocoa commented 4 months ago

I wondered if

https://github.com/headspinio/appium-tizen-tv-driver/blob/fe9dd0b1a8b13647dfc73c47ef72b37965caff2c/packages/appium-tizen-tv-driver/lib/driver.js#L370-L374

can have executableDir: opts.chromedriverExecutableDir and isAutodownloadEnabled: isChromedriverAutodownloadEnabled.bind(this)() to enable autodownload in addition to explicit driver path only.

https://github.com/appium/appium-android-driver/blob/4bead422c2f36e8a019073b6acba0853ba9b40e4/lib/commands/context/helpers.js#L712C1-L728C6

Then, the executable or chromedriverExecutableDir should be required, but not both.

As same as the Android, the autodownload should be behind the same security flag.