headwayio / voyage

A Rails template with our standard defaults, ready to deploy to Heroku. **See readme in: lib/voyage/README.md**
https://headway.io/voyage
MIT License
0 stars 1 forks source link

Make API compatible #3

Closed jondkinney closed 7 years ago

jondkinney commented 7 years ago

Add Gems:

Look at test setup:

jondkinney commented 7 years ago

@noahsettersten thoughts on this after running it in the context of hypremium? Is there anything we can do to automate this with a prompt up front during generation time?

noahsettersten commented 7 years ago

The three items you referenced would be my thoughts for API-specific changes.

I can see adding an API / token option during setup to take care of creating the necessary database migration and code changes to allow the User model to be token authenticatable. We could also add the JSON handling and tests as well. Most of my time getting the app up and running was spent on writing RSpec/capybara tests to get code coverage up. Instead of lowering the minimum coverage needed, I took it as an opportunity to learn more of those skills.

A few other things that we may want to consider adding unrelated to the API usecase:

noahsettersten commented 7 years ago

Doing a recent generate from your new branch (now in master), I believe these have all been done. I'm going to hold off on adding the new 'API' setup option for a future issue to rollup jsonapi-utils and tiddle as well.