Driver

[Fankhauser-Dominik]

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

• Before: https://main--eds-self-service-website--headwire-edge-delivery.hlx.live/
• After: https://driver--eds-self-service-website--headwire-edge-delivery.hlx.live/

[aem-code-sync[bot]]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

• [ ] Re-run PSI checks
• [ ] Re-sync branch

Commits

* [b7194d5](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/b7194d5bf19d9d3ec997f73b92c83e077b133ed2) :white_check_mark: (latest) * [543bee4](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/543bee4432598cb713b2920a10c5cac700ef01b1) :white_check_mark: * [3156a5f](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/3156a5f26f7160f71585d5386bb8146c9d61a3ea) :white_check_mark: * [7eba465](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/7eba4654976c73f7693fa993ba9984ebba4dd7b2) :white_check_mark: * [d06e3af](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/d06e3af77a4a16edbb29f3ac342ce411ff437a59) :white_check_mark: * [e7de007](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/e7de0072f14d1d8b2fa4a963ddfc1a9c9438cf71) :white_check_mark: * [7db35b2](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/7db35b2ccbf4e1066378e71ee12878d4f8ea75f0) :white_check_mark: * [68cfedc](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/68cfedc93017cd8c13bf6aec5a72f66a40742f04) :white_check_mark: * [9cf1a29](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/9cf1a295ed11132d74a3a70fe38bbe2c49553270) :white_check_mark: * [e843256](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/e8432560bbfc45bf19bf32d9d22f03c5008b3f78) :white_check_mark: * [0e0cc83](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/0e0cc835e13f0275426f1194e0e8fee4e160f728) :white_check_mark: * [f43653a](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/f43653ad4c5b9ca6c0cc85b8b3569c7e6d6e612f) :white_check_mark: * [2b4534a](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/2b4534a6b567f0c06c5cde75e70da25fcead4b2f) :white_check_mark: * [2a7cc87](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/2a7cc877c6728f5f2b35db7c2c47b4b0010e1d63) :white_check_mark: * [798daa2](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/798daa23a4fa5b105d14c6c87f31e39cd8abe9c8) :white_check_mark: * [bfdaa51](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/bfdaa51ed892ea5502a5339114325865e5e3c648) :white_check_mark: * [4515a8d](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/4515a8d715476be81b44654e850fd978843ecfff) :white_check_mark: * [7f0e638](https://github.com/headwire-edge-delivery/eds-self-service-website/commit/7f0e63874a81954ebed5c8b54cfac2f67a6d2522) :white_check_mark:

[aem-code-sync[bot]]

Page	Scores	Audits	Google
/

[icaraps]

There's another PR https://github.com/headwire-edge-delivery/eds-self-service-website/pull/24 which we could merge before but then it means we would have to add it to the tour.

[icaraps]

FYI https://github.com/headwire-edge-delivery/eds-self-service-website/pull/24 was merged which also means new merge conflicts incoming ...

[icaraps]

@DriftingSands can you pls review as well since the PR affects everything its better to have more eyes on it.

[DriftingSands]

I guess before, all cards just happened to be the same size. We should use flex: 1; now

[DriftingSands]

Tour did not automatically start here & I think I got the wrong one after clicking help button.

We should tell users what each button here does, and guide them through. And it should open automatically

[icaraps]

I guess before, all cards just happened to be the same size. We should use flex: 1; now

We should retake the screenshots for all templates and make sure they have all same dimensions. That can be done later.

[DriftingSands]

I guess before, all cards just happened to be the same size. We should use flex: 1; now

We should retake the screenshots for all templates and make sure they have all same dimensions. That can be done later.

Even then I think flex: 1 as a fallback makes sense

[DriftingSands]

this pops up at the end of every tour. It's quite annoying, as I don't want to disable the automatic tour yet. I haven't seen everything.

Also the tour doens't trigger automatically anymore anywhere? I haven't been on site-details before, I keep having to click help to get it to show up.

EDIT: On the theme editor the tour did trigger automatically. So on create site & theme editor it started automatically, but every other page didn't

[DriftingSands]

Update section should get a small tour too

[Fankhauser-Dominik]

I guess before, all cards just happened to be the same size. We should use flex: 1; now

It wasn't the same size before. It's becaus of this: .wizard.block .template { margin: auto auto 32px; }

[DriftingSands]

Next, Prev, Done button on the tour pop-ups have no visible keyboard focus. Theres a small animation, but its hard to spot, start & end is the same style

[icaraps]

We should retake the screenshots for all templates and make sure they have all same dimensions. That can be done later.

I just did it. Not sure if its automatically reflected on this branch ...