headwirecom / jsonforms-react-spectrum-renderers

Other
8 stars 4 forks source link

Example "oneOf (in array)": Expandable table rows with delete button #52

Closed hupf closed 3 years ago

hupf commented 3 years ago

With the vanilla renderer, an empty table with a plus button that does not work is rendered.

With the Material renderer, a table with expandable rows that contain the form, and a delete button on each row, is rendered:

image

With our Spectrum renderer we directly render the forms vertically, without the possibility to delete entries:

image

Should we add delete buttons? Should the forms be collapsable? Should we use a table layout?

mburri commented 3 years ago

We should not use tables. We create a custom component (check out the group component for inspiration) and add a header toolbar with controls (delete, collapse icon)

mburri commented 3 years ago

fixed by #85